Add verify option to allow query developers to skip SSL certificate verification #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 20, 2020
| @@ -91,6 +91,7 @@ You can pass additional keys to modify various HTTP options: | |||
| * `params` - a dictionary of query string parameters to add to the URL | |||
| * `data` - a dictionary of values to use as request body | |||
| * `json` - same as `data` except that it's being converted to JSON | |||
| * `verify` - whether or not to enforce SSL certificate verification (default: `true`) | |||
There was a problem hiding this comment.
Suggested change
| * `verify` - whether or not to enforce SSL certificate verification (default: `true`) | |
| * `verify` - whether or not to enforce SSL certificate verification (default: `true`, _new in Redash v10_) |
Added a comment about it being new so we don't confuse users.
kravets-levko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanies getredash/redash#5212